Added support for responses longer than 4 hex digits #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are PID commands that result in responses longer than 4 hex digits. For example
223277
code for opel insignia returns 6 hex digits response (kms since last dpf regeneration). I logged some variables when debugging the PID:As you can see the response should be
00000E
(15km since dpf regeneration) but currently it returns0000
since implementation is fixed on only two types of responses size (2 and 4 digits).I added more generic implementation which reads everything from
firstDatum
till the end thus allowing any response size.I've done some regression testing with multiple commands on opel insignia and found it works fine
Let me know what you think