Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add warnings about large values passed to setMaxTCPClientThreads #14534

Merged

Conversation

rgacogne
Copy link
Member

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10142819164

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • 46 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.01%) to 64.634%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/dnsdist.cc 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
pdns/ueberbackend.cc 1 81.85%
pdns/recursordist/syncres.cc 1 79.42%
pdns/recursordist/aggressive_nsec.cc 2 66.39%
ext/json11/json11.cpp 2 62.72%
pdns/rcpgenerator.cc 2 89.86%
pdns/misc.cc 2 63.26%
pdns/dnsdistdist/dnsdist.cc 2 68.54%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/opensslsigners.cc 3 61.34%
pdns/recursordist/rec-tcpout.cc 5 50.79%
Totals Coverage Status
Change from base Build 10139890791: -0.01%
Covered Lines: 124575
Relevant Lines: 162046

💛 - Coveralls

@rgacogne rgacogne merged commit 9654aa2 into PowerDNS:master Aug 29, 2024
79 checks passed
@rgacogne rgacogne deleted the ddist-warn-setmaxtcpclientthreads branch August 29, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants