auth: encapsulate lookup()-cleanup

[zeha]

Short description

Encapsulate this pattern into a new function:

while (B.get(rr)) ;      // don't leave DB handle in bad state

I've tentatively called the function lookupEnd.

This is a tiny improvement and probably opens a can of clang-tidy worms. I'll preemptively say that a solution which would instead remove the need to explicitly call this would be better, but that can still come.

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[coveralls]

Pull Request Test Coverage Report for Build 10593278659

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 9 of 13 (69.23%) changed or added relevant lines in 2 files are covered.
• 59 unchanged lines in 13 files lost coverage.
• Overall coverage increased (+0.02%) to 64.69%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pdns/ueberbackend.cc	8	9	88.89%
pdns/packethandler.cc	1	4	25.0%

Files with Coverage Reduction	New Missed Lines	%
ext/json11/json11.cpp	1	64.49%
pdns/pollmplexer.cc	1	83.66%
pdns/recursordist/sortlist.cc	2	72.94%
pdns/recursordist/aggressive_nsec.cc	2	66.17%
pdns/sstuff.hh	2	56.83%
pdns/recursordist/syncres.cc	2	79.35%
pdns/stubresolver.cc	3	77.58%
pdns/dnsdistdist/dnsdist-tcp.cc	4	76.18%
pdns/signingpipe.cc	5	85.75%
pdns/misc.cc	5	63.26%

Totals
Change from base Build 10593239165:	0.02%
Covered Lines:	124686
Relevant Lines:	162063

---

💛 - Coveralls

[zeha]

opens a can of clang-tidy worms

No worms showed up. 😮

[Habbie]

I'll preemptively say that a solution which would instead remove the need to explicitly call this would be better, but that can still come.

It has seemed obvious for quite some time now that having lookup() just fill a vector likely makes more sense. Some backends already do this internally.

[zeha]

I'll preemptively say that a solution which would instead remove the need to explicitly call this would be better, but that can still come.

It has seemed obvious for quite some time now that having lookup() just fill a vector likely makes more sense. Some backends already do this internally.

Ah yes, I was pondering this. Can take a look sometime; might still be nice to merge this in the meantime.

[Habbie]

might still be nice to merge this in the meantime.

will do when green!