Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: make chain test more robust and fix max chain size accounting #14669

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

omoerbeek
Copy link
Member

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@omoerbeek omoerbeek added the rec label Sep 13, 2024
@omoerbeek
Copy link
Member Author

Hold off, I think I committed the wrong version

@omoerbeek omoerbeek marked this pull request as draft September 13, 2024 09:40
@omoerbeek omoerbeek marked this pull request as draft September 13, 2024 09:40
@omoerbeek omoerbeek marked this pull request as draft September 13, 2024 09:40
@omoerbeek omoerbeek force-pushed the rec-chain-test-tweaks branch 2 times, most recently from a982384 to a828713 Compare September 13, 2024 09:57
@omoerbeek omoerbeek changed the title rec: make chain test more robust rec: make chain test more robust and fix max chain size accounting Sep 13, 2024
@coveralls
Copy link

coveralls commented Sep 13, 2024

Pull Request Test Coverage Report for Build 10848806902

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 103 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.03%) to 64.673%

Files with Coverage Reduction New Missed Lines %
pdns/backends/gsql/gsqlbackend.hh 1 97.71%
pdns/misc.cc 2 63.6%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/rcpgenerator.cc 3 89.68%
pdns/recursordist/test-syncres_cc1.cc 5 89.75%
pdns/signingpipe.cc 5 83.11%
pdns/recursordist/syncres.cc 11 79.54%
pdns/recursordist/taskqueue.cc 11 34.15%
pdns/recursordist/rec-tcp.cc 14 64.4%
modules/lmdbbackend/lmdbbackend.cc 14 72.5%
Totals Coverage Status
Change from base Build 10847178982: -0.03%
Covered Lines: 124803
Relevant Lines: 162270

💛 - Coveralls

@omoerbeek omoerbeek force-pushed the rec-chain-test-tweaks branch 2 times, most recently from d67ae45 to 0902358 Compare September 13, 2024 11:44
@omoerbeek omoerbeek marked this pull request as ready for review September 13, 2024 12:49
@omoerbeek omoerbeek merged commit 2ee3afa into PowerDNS:master Sep 13, 2024
79 checks passed
@omoerbeek omoerbeek deleted the rec-chain-test-tweaks branch September 13, 2024 15:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants