Upgrades, loggers and GetBackendWithParams #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wojas
commented
Nov 1, 2022
•
wojas
commented
- Upgrade the minio S3 client
- Upgrade other Go dependencies
- Upgrade go-tlsconfig
- Start using logr.Logger to pass a logger to backends and add it to InitParams
- S3: pass the logger to go-tlsconfig
- Add new GetBackendWithParams function, which allows passing a logger
- Deprecate GetBackend in favor of GetBackendWithParams
- Add Go 1.19 to Github CI and drop Go 1.17
- Upgrade the minio S3 client - Upgrade other Go dependencies - Upgrade go-tlsconfig - Start using logr.Logger to pass a logger to backends and add it to InitParams - S3: pass the logger to go-tlsconfig - Add new GetBackendWithParams function, which allows passing a logger - Deprecate GetBackend in favor of GetBackendWithParams - Add Go 1.19 to Github CI
Upgrading golangci-lint caused it to fail to build with Go 1.17, so I decided to drop 1.17 and bump the version in go.mod. The code itself probably still works under 1.17, but this is no longer guaranteed.
nvaatstra
reviewed
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.