Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily add DCO check #625

Merged
merged 4 commits into from
Jun 5, 2024
Merged

temporarily add DCO check #625

merged 4 commits into from
Jun 5, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Jun 5, 2024

Temporary workaround to do the DCO check ourselves because the DCO app is stuck (see dcoapp/app#211 )

To be reverted in #626

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the dependencies Pull requests that update a dependency file label Jun 5, 2024
@mgovers mgovers marked this pull request as ready for review June 5, 2024 08:14
@Jerry-Jinfeng-Guo
Copy link
Contributor

For other approved PRs, do we need to push empty commit to trigger the ci?

@mgovers
Copy link
Member Author

mgovers commented Jun 5, 2024

For other approved PRs, do we need to push empty commit to trigger the ci?

that wouldn't be sufficient because the workflow wouldn't be there. merge with main would do the trick

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue Jun 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2024
@mgovers
Copy link
Member Author

mgovers commented Jun 5, 2024

merge queue build failed due to actions/runner-images#10001

@mgovers mgovers added this pull request to the merge queue Jun 5, 2024
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2024
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact: refine is to re finish. So technically there is no pre-refine.

Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mgovers mgovers added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit fd1802b Jun 5, 2024
24 checks passed
@mgovers mgovers deleted the feature/temporary-dco-check branch June 5, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants