Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change pre-commit config .yaml file #627

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

zhen0427
Copy link
Contributor

@zhen0427 zhen0427 commented Jun 5, 2024

No description provided.

Signed-off-by: Zhen Wang <zhen.wang@alliander.com>
@zhen0427 zhen0427 requested a review from mgovers June 5, 2024 09:36
@mgovers
Copy link
Member

mgovers commented Jun 5, 2024

please tell me the windows runners are not broken again

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\include\yvals_core.h(898,1): error: static assertion failed: error STL1000: Unexpected compiler version, expected Clang 17.0.0 or newer.
_EMIT_STL_ERROR(STL1000, "Unexpected compiler version, expected Clang 17.0.0 or newer.");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\include\yvals_core.h(519,44): note: expanded from macro '_EMIT_STL_ERROR'
#define _EMIT_STL_ERROR(NUMBER, MESSAGE)   static_assert(false, "error " #NUMBER ": " MESSAGE)

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@mgovers
Copy link
Member

mgovers commented Jun 5, 2024

build fails due to actions/runner-images#10001

mgovers and others added 2 commits June 5, 2024 22:46
Co-authored-by: Martijn Govers <martijn.govers@alliander.com>
Signed-off-by: Zhen Wang <Zhen.Wang@alliander.com>
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit 585d5bb Jun 7, 2024
25 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/update-precommit branch June 7, 2024 11:00
@mgovers mgovers mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants