This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Performance improvements, memory leak and misc other fixes and drop binary size by ~4% #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signed off, some good refactoring in here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest change is the introduction of base classes to dedupe shared code. Drops binary size by ~4%, but the tradeoff is slightly reduced type safety at the lowermost interop layer. As that layer is now mostly hidden by helper layers I feel the tradeoff is worth the improvement. Next biggest change is a cache of function table pointers to avoid unnecessary marshal calls.