This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Apply mitigation to CimInstance disposal race condition #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disables automatic cleanup of base class memory, which appears to have been the cause of the race condition. The finalizer for the MI_Instance base class was running ahead of the CimInstance finalizer, causing the allocated block to be cleaned up before an explicit Delete() on the part of the CimInstance finalizer. This change switches to a Dispose() model for freeing MI_NativeObject instances, though it does not carry-through the usage to all appropriate places. As a result this change introduces a rather meaningful memory leak, but the leak is preferable to the crash in the near term as it was slowing down development.