Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not directly set cursor on AcceptLineImpl #1182

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

msftrncs
Copy link
Collaborator

@msftrncs msftrncs commented Nov 14, 2019

In AcceptLineImpl(), instead of _console.SetCursorPosition(), use public API SetCursorPosition() so that existing end of buffer checks can be performed.

Fixes #1181, complement to #1146.
May fix #1155.

Instead of _console.SetCursorPosition(), use public API SetCursorPosition
so that existing end of buffer checks can be performed.

Fixes PowerShell#1181
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants