-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModuleHelp.Tests.ps1 throws false positives #1417
Comments
@Jawz84 thanks for opening this issue and linking the PR |
* fix modulehelp false positives When looking up module version, if the module is not installed, also check if it is loaded and get module version from loaded module Add 'AttachAndDebug' to paramBlackList, so it does not throw false positives for DEBUG builds. Small bugfix for the actual blacklist check, the property 'name' of the $parameter variable needs to be used to check against the blacklist. * undo check for loaded module, because $env:psmodulepath is set to .\out\ module during testing, the built module will always appear 'installed'. * simplify command discovery
Yes, thanks, I've merged it in now. I've changed the labels though from bug to build as this is not a bug in the actual product but rather the internal build/test system |
Thanks for taking the time to write that, I understand you had to try a few times and do it from mobile because it wouldn't work from desktop 👍 |
No worries, that problem I mentioned on Twitter earlier applied to this much bigger comment actually (where I decide to just copy paste the text into a draft email to be able to copy paste from my mobile...) 😅 Commenting works now again from Desktop :-) I've seen some of the updates in your other PR and want to take some time this week to fully review it but from a glance it looks already good |
There are small problems in the
ModuleHelp.Tests.ps1
file when running tests on Pwsh, or running on an environment without PSScriptAnalyzer actually installed.affected areas:
Steps to reproduce
.\PSScriptAnalyzer\build.ps1 .\PSScriptAnalyzer\build.ps1 -Test
Expected behavior
Actual behavior
.\PSScriptAnalyzer\out\
The text was updated successfully, but these errors were encountered: