Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload only out folder as artifact, which is the actual PSSA artifact #1009

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Jun 2, 2018

PR Summary

As per title, at the moment, we upload the full repo, which is not necessary, just the out folder is enough
Related #622
Should we document this and give details which build to choose (since all builds build only for their specific PowerShell version) and tell having to unblock the zip?
To fully close the issue we would need to change one of the build jobs to build for all PowerShell versions.
WDYT?

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking
  • NA Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Copy link
Member

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesWTruher JamesWTruher merged commit dc0b4a3 into PowerShell:development Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants