Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant/outdated build scripts and cleanup #1011

Merged
merged 13 commits into from
Jul 19, 2018

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Jun 2, 2018

PR Summary

  • Fixes Time to get rid of build.cmd? #787 by removing build.cmd which was left over from the days before the dotnet cli
  • Remove .build.ps1, which is not needed and seems to be an accidental copy-paste check-in from a couple of years ago
  • Various cleanup and fixing of PSSA warnings in build scripts about PSPossibleIncorrectComparisonWithNull and PSAvoidTrailingWhitespace
  • Set VSCode setting to automatically trim triailing whitespace
  • Set the PowerShell and C# extensions as recommended extensions in the .vsode folder (i.e. when people open vscode and don't have those extensions, then vscode will recommend them)

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking
  • Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister bergmeister self-assigned this Jun 2, 2018
@bergmeister bergmeister changed the title Remove redundant/outdated build.cmd and related parameters in build.ps1 Remove redundant/outdated build scripts and cleanup Jun 3, 2018
Copy link
Member

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the JSON thing, this looks fine

@@ -0,0 +1,8 @@
{
// See http://go.microsoft.com/fwlink/?LinkId=827846
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think that comments were allowed in JSON

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, per JSON standard, you are right but it's no problem for VSCode, similar comments are also in the .vscode folder of the PowerShell Core repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

Copy link
Member

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the JSON thing, this looks fine

@JamesWTruher JamesWTruher merged commit 6e85ec0 into PowerShell:development Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time to get rid of build.cmd?
2 participants