Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OutputType attributes to cmdlets to enhance tab completion #1020

Merged
merged 7 commits into from
Jul 19, 2018

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Jun 8, 2018

PR Summary

Closes #1019 as requested/suggested by @SeeminglyScience

Add OutputType attributes to the cmdlets to help e.g. tab completion.
Example of what this enables:

Get-ScriptAnalyzerRule | Select-Object
TAB
Get-ScriptAnalyzerRule | Select-Object CommonName

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking
  • Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister bergmeister self-assigned this Jun 8, 2018
@bergmeister bergmeister added this to the 1.18 milestone Jun 8, 2018
@bergmeister bergmeister changed the title WIP Add OutputType attributes to cmdlets to enhance tab completion Add OutputType attributes to cmdlets to enhance tab completion Jun 8, 2018
@bergmeister
Copy link
Collaborator Author

bergmeister commented Jun 8, 2018

Build failure is only due to the new Ubuntu image missing the Push-AppveyorArtifact cmdlet, I raised an issue here: appveyor/ci#2428
EDIT They responed quickly and have fixed the issue now

Copy link
Member

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesWTruher JamesWTruher merged commit a54a99c into PowerShell:development Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-ScriptAnalyzerRule should declare OutputType
2 participants