Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Microsoft.PowerShell.5.ReferenceAssemblies from 1.0.0 to 1.1.0 and remove redundant/transitive references #1050

Merged

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Jul 28, 2018

PR Summary

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking (I hope so)
  • NA Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister bergmeister changed the title Upgrade Microsoft.PowerShell.5.ReferenceAssemblies from 1.0.0 to 1.1.0, which was already published last year WIP Upgrade Microsoft.PowerShell.5.ReferenceAssemblies from 1.0.0 to 1.1.0, which was already published last year Jul 28, 2018
@bergmeister bergmeister changed the title WIP Upgrade Microsoft.PowerShell.5.ReferenceAssemblies from 1.0.0 to 1.1.0, which was already published last year Upgrade Microsoft.PowerShell.5.ReferenceAssemblies from 1.0.0 to 1.1.0 and remove redundant/transitive references Jul 28, 2018
Copy link
Member

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that the earlier reference references were wrong. Is there a reason why we're not referencing the proper versions of the PS references? PowerShell 3 reference for the PSV3 analyzer, etc.?

@bergmeister
Copy link
Collaborator Author

@JamesWTruher We are referencing the correct one for each ps version (i,e. 6, 3, 4 and 5) in the Engine project here. Because the rules project depends on the Engine, some references were not needed as they were inherited as a transitive reference.

@bergmeister bergmeister merged commit 7218b2d into PowerShell:development Aug 21, 2018
bergmeister added a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 22, 2019
…0 and remove redundant/transitive references (PowerShell#1050)

* Upgrade Microsoft.PowerShell.5.ReferenceAssemblies from 1.0.0 to 1.1.0, which was already published last year

* Remove transitive and redundant references.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants