Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RuntimeFrameworkVersion as this is given by the running version of PS anyway and .Net would upgrade automatically anyway if possible #1052

Merged

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Jul 28, 2018

PR Summary

  • Remove RuntimeFrameworkVersion as this is given by the running version of PS anyway and .Net would upgrade automatically anyway if possible
  • Also remove PackageTargetFallback as a cleanup, this was a leftover from the days of .Net Core 1.0

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking
  • NA Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

…n of PS anyway and .Net would upgrade automatically anyway if possible
@bergmeister bergmeister merged commit 353c2be into PowerShell:development Aug 20, 2018
bergmeister added a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 22, 2019
…n of PS anyway and .Net would upgrade automatically anyway if possible (PowerShell#1052)

* Remove RuntimeFrameworkVersion as this is given by the running version of PS anyway and .Net would upgrade automatically anyway if possible

* revert change of encoding

* Remove PackageTargetFallback, which was a leftover from .Net Core 1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants