Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation of PSUseConsistentWhiteSpace: enhance example and correct argument type. #1069

Merged
merged 1 commit into from
Sep 15, 2018
Merged

Update documentation of PSUseConsistentWhiteSpace: enhance example and correct argument type. #1069

merged 1 commit into from
Sep 15, 2018

Conversation

Halkcyon
Copy link
Contributor

@Halkcyon Halkcyon commented Sep 10, 2018 •
edited by bergmeister
Loading

IndentationSize had the wrong type attributed to it. Added use of Kind in the example.

PR Summary

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking
  • [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@Halkcyon
Updated example and corrected argument type.
889c9b9 
IndentationSize had the wrong type attributed to it.  Added use of `Kind` in the example.
bergmeister
bergmeister approved these changes Sep 10, 2018
View reviewed changes
Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bergmeister bergmeister changed the title Updated example and corrected argument type. Updated documentation of PSUseConsistentWhiteSpace: enhance example and corrected argument type. Sep 10, 2018
@bergmeister bergmeister changed the title Updated documentation of PSUseConsistentWhiteSpace: enhance example and corrected argument type. Update documentation of PSUseConsistentWhiteSpace: enhance example and correct argument type. Sep 10, 2018
@bergmeister bergmeister merged commit 15eadb8 into PowerShell:development Sep 15, 2018
bergmeister pushed a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 22, 2019
@Halkcyon @bergmeister
Updated example and corrected argument type. (PowerShell#1069)
f6cee68 
IndentationSize had the wrong type attributed to it.  Added use of `Kind` in the example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmeister bergmeister bergmeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Halkcyon @bergmeister