Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps SDK version to 2.1.401 #1086

Merged
merged 8 commits into from
Oct 23, 2018
Merged

Bumps SDK version to 2.1.401 #1086

merged 8 commits into from
Oct 23, 2018

Conversation

wilmardo
Copy link
Contributor

@wilmardo wilmardo commented Oct 22, 2018

PR Summary

Implements: #1085

Updates SDK version to 2.1.401 in global.json

PR Checklist

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the change looks ok but please update the link in the readme as well. I don't know why but the CI trigger does not seem to work today. cc @JamesWTruher

@wilmardo
Copy link
Contributor Author

The version and link in the readme are updated as well.
Also changed or newer to or newer patch release since a newer version which isn't a patch release of 2.1.401 will trow an error as stated in the docs:

  • If the specified SDK version is found on the machine, that exact version is used.
  • If the specified SDK version can't be found on the machine, the latest installed SDK patch version of that version is used. Latest installed SDK patch version can be either release or pre-release - the highest version number wins. In .NET Core 2.1 and higher, the patch versions lower than the patch version specified are ignored in the SDK selection.
  • If the specified SDK version and an appropriate SDK patch version can't be found, an error is thrown.

@msftclas
Copy link

msftclas commented Oct 22, 2018

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and the CI build is green now as well after the GitHub outage

@bergmeister bergmeister merged commit 2df52ab into PowerShell:development Oct 23, 2018
bergmeister pushed a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 22, 2019
* Bumps SDK version to 2.1.401

* Updates version and url in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants