Install dotnet sdk if missing on Unix as well to fix failing Ubuntu build due to image update and Pester/PowerShell bug #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her changes that would break break wmf4
6 tasks
bergmeister
changed the title
JamesWTruher
approved these changes
Jan 9, 2019
6 tasks
bergmeister
added a commit
to bergmeister/PSScriptAnalyzer
that referenced
this pull request
Mar 22, 2019
…uild due to image update and Pester/PowerShell bug (PowerShell#1107) * add unix support for installing the .net core sdk on-demand * add logging * update sdk * adapt for dotnet writing to stderr * fix parenthesis * only set protocol if needed and set erroraction to avoid ci failur * try fix nullreferenceexception * use use --list-sdks * use 2.1.403 sdk, which is at least available on Windows * use erroractionpreference * redirect error * use continue * use 2.1.400 that is available on both windows and linux and revert other changes that would break break wmf4 * remove if check that could break wmf4? * use --list-sdks * try different syntax to get wmf4 to work * disable wmf4 for the moment * use 2.1.403 and re-enable wmf4 * fix typo (wmf4) * use .net core sdk 2.1.502 * ignore 5 pester failure on Ubuntu for AppVeyor due Pester/PowerShell bug that happens on AppVeyor environment * Fix typo * add more skip statements for failing appveyor tests * Revert "add more skip statements for failing appveyor tests" This reverts commit 064683f. * Revert "Fix typo" This reverts commit 61c4d59. * Revert "ignore 5 pester failure on Ubuntu for AppVeyor due Pester/PowerShell bug that happens on AppVeyor environment" This reverts commit 8c48e93. * set locale * empty * Revert "set locale" This reverts commit ee79467. * simplify dotnet check * output debug details and disable other images * output rule names * output more * add more and downgrade sdk * use 2.1.403 sdk * 2.1.401 sdk * 2.1.400 sdk * Revert "simplify dotnet check" This reverts commit 7db40c3. * 2.1.401 * 2.1.403 * 2.1.502 * fix resource string casing of AvoidUsingUsernameAndPassWordParams to AvoidUsingUsernameAndPasswordParams * another resource string casing optimisation * use OrdinalIgnoreCase to be really case insensitive * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The build is failing on Linux at the moment because the required SDK is missing due to an image update and
dotnet --versionbinary now throw is minor version differs, therefore also update SDK version. Improvement to restoring security protocol is similar to already approved PR #1076. There were initially also 5 test failures on Linux but they were bugs when using PowerShell 6.1.1 due to it being partially case sensitive on that environment. They started happening after the image updated PowerShell from 6.0.2 to 6.1.1, see here for the logged issue of Pester with PSCore 6.1 on Linux.EDIT: a hotfix has been published for Pester now and I made some small tweaks so everything is green now
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.