Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting regression in 1.18.0 whereby single-line pipeline reduces indentation level incorrectly #1191

Conversation

bergmeister
Copy link
Collaborator

PR Summary

Fixes #1187 by excluding single-line pipelines to avoid reduce indentation level incorrectly. This case showed up only when there is already some indentation.

PR Checklist

…rrectly (problem only showed up when there was already existing indentation due to ClipNegative
Rules/UseConsistentIndentation.cs Outdated Show resolved Hide resolved
Rules/UseConsistentIndentation.cs Show resolved Hide resolved
Rules/UseConsistentIndentation.cs Show resolved Hide resolved
Rules/UseConsistentIndentation.cs Show resolved Hide resolved
Co-Authored-By: bergmeister <c.bergmeister@gmail.com>
@bergmeister
Copy link
Collaborator Author

I applied the suggestions, I have to look at the test failures though, locally it was fine.

Copy link
Member

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like this isn't quite right based on test failures

@bergmeister
Copy link
Collaborator Author

@rjmholt @JamesWTruher @TylerLeonhardt I fixed the build, it was a simple mistake, I used a break statement when I actually meant to use a continue statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.18.0 - Incorrect indentation of brace after pipe
3 participants