Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update signing file for versioned location of module #1253

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

JamesWTruher
Copy link
Member

PR Summary

These are the changes to build and sign script analyzer in VSTS.

PR Checklist

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to you but I suggest to do XML editing the file at runtime to put the version number into it, even just putting a placeholder and doing a simple string replace would do the job as well IMHO whilst keeping it simple

@bergmeister bergmeister added this to the 1.18.1 milestone Jun 6, 2019
@JamesWTruher
Copy link
Member Author

@bergmeister Agreed - when we move to VSTS CI I'm planning on a bit of a rewrite to generate more of this. For 1.18.1 I'll just do it manually, especially as the release is imminent.

@JamesWTruher JamesWTruher merged commit ab0fc4f into PowerShell:development Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants