Disable bad tests on Linux for now #1365

rjmholt · 2019-11-04T05:06:34Z

PR Summary

Disables tests that a strangely failing only on Linux in AppVeyor.

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Tests/Rules/UseCompatibleCommands.Tests.ps1

bergmeister

Looks good, just one minor suggestion to disable those 4 tests on appveyor only as those tests pass on azure devops's ubuntu image

Co-Authored-By: Christoph Bergmeister [MVP] <c.bergmeister@gmail.com>

Disable bad tests on Linux for now

31952b0

rjmholt requested review from bergmeister and JamesWTruher November 4, 2019 05:06

bergmeister reviewed Nov 6, 2019

View reviewed changes

Tests/Rules/UseCompatibleCommands.Tests.ps1 Outdated Show resolved Hide resolved

bergmeister reviewed Nov 6, 2019

View reviewed changes

Tests/Rules/UseCompatibleCommands.Tests.ps1 Outdated Show resolved Hide resolved

bergmeister approved these changes Nov 6, 2019

View reviewed changes

Apply suggestions from code review

dc2be6a

Co-Authored-By: Christoph Bergmeister [MVP] <c.bergmeister@gmail.com>

rjmholt merged commit ca1b7c0 into PowerShell:master Nov 7, 2019