Remove redundant whitespace between parameters with new option (disabled by default) in UseConsistentWhitespace #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmeister
changed the title
rjmholt
reviewed
Jan 6, 2020
Co-Authored-By: Robert Holt <rjmholt@gmail.com>
…ghtExtent variable, which broke build. Variable is used 2 times and makes code more readable, therefore keeping it
|
@rjmholt Thanks for the review, I addressed all recommendations |
rjmholt
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Disabled by default because it is new. The plan is to later add an option to the vs code extension and pending positive feedback we can then later enable it by default.
The only case that was excluded by design is when the user uses the
-ParameterName:$ParameterValuesyntax as some people might prefer 0 or 1 whitespace here, the rule leaves those cases completely untouched.PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.