Fix ps3 syntax check #1395

rjmholt · 2020-01-16T01:23:33Z

PR Summary

UseCompatibleSyntax used to erroneously advise that dynamic member expressions don't work in PS 3. Now it does not.

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

bergmeister

Apart from the question around why severity changed, looks ok but the build is not green, therefore once the build is green, I think it can go in

Rules/CompatibilityRules/UseCompatibleSyntax.cs

rjmholt · 2020-01-16T21:21:26Z

looks ok but the build is not green, therefore once the build is green, I think it can go in

100% agreed, will work on that this week hopefully.

rjmholt added 4 commits January 15, 2020 17:20

Remove erroneous ps3 dynamic member warning

5a42e28

Upgrade compatible syntax rule to emit errors

0a74ee6

Fix tests

8bde76d

Fix last test

4e1bfeb

bergmeister reviewed Jan 16, 2020

View reviewed changes

Rules/CompatibilityRules/UseCompatibleSyntax.cs Show resolved Hide resolved

Fix tests to account for severity change

fc0ccbe

bergmeister merged commit a415198 into PowerShell:master Feb 4, 2020