Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ps7 syntax #1426

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Ps7 syntax #1426

merged 2 commits into from
Mar 31, 2020

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Mar 11, 2020 •
edited

PR Summary

Waiting on #1425.

Adds syntax checking for new PowerShell 7 syntaxes.

PR Checklist

@rjmholt rjmholt requested review from bergmeister and JamesWTruher and removed request for bergmeister March 11, 2020 20:41
@rjmholt rjmholt marked this pull request as ready for review March 31, 2020 21:40
bergmeister
bergmeister approved these changes Mar 31, 2020
View reviewed changes
Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the tests comes back green as well :-)

@rjmholt rjmholt merged commit 2514855 into PowerShell:master Mar 31, 2020
@bergmeister bergmeister mentioned this pull request May 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmeister bergmeister bergmeister approved these changes

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rjmholt @bergmeister