Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rule suppression ID in compat rules #1432

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Apr 3, 2020

PR Summary

The ruleId wasn't translated through in the compatibility diagnostic constructor. This fixes that.

PR Checklist

@rjmholt
Copy link
Contributor Author

rjmholt commented Apr 3, 2020

image

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can an existing test be enhanced for an additional assertion against the rule id if easily possible? Otherwise LGTM

@rjmholt
Copy link
Contributor Author

rjmholt commented Apr 3, 2020

Can an existing test be enhanced for an additional assertion against the rule id if easily possible?

I'm thinking a similar thing, but I'd like to do that in a separate PR (which might be able to enhance these suppressions slightly as well)

@rjmholt rjmholt merged commit 975fcc6 into PowerShell:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants