Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Newtonsoft.Json from 12.0.2 to 12.0.3 in Compatibility project as well #1447

Merged
merged 2 commits into from
Apr 17, 2020

Conversation

bergmeister
Copy link
Collaborator

PR Summary

PowerShell 6.2.4 uses this version as well, therefore not an issue: https://github.com/PowerShell/PowerShell/blob/v6.2.4/src/System.Management.Automation/System.Management.Automation.csproj
The upgrade to this version technically already happened in PR #1425 but this project was did not get updates.

PR Checklist

@bergmeister
Copy link
Collaborator Author

bergmeister commented Apr 17, 2020

That's funny, one of the tests jobs failed because I merged PR #1446 AFTER the build had already started, meaning that when the test job checked out out the repo, it executed the newly added tests but of course the build artefact did not have the code to make it pass that test... I suppose this does not happen very often but it's good to be aware of this because the traditional re-run of the test stage did not help here of course. Technically, we should probably upload the Tests folder as an artefact to avoid this but that would make CI unnecessarily more complex I fear.

@bergmeister bergmeister merged commit 9098e76 into master Apr 17, 2020
@bergmeister bergmeister deleted the bergmeister-patch-3 branch October 24, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants