Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Assembly version attribute for 1.19.1 release #1549

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

JamesWTruher
Copy link
Member

@JamesWTruher JamesWTruher commented Jul 21, 2020

PR Summary

this change puts an assembly version on the analyzer assemblies, so you can see the version by inspection of the assembly

PR Checklist

@rjmholt rjmholt requested a review from bergmeister July 21, 2020 22:08
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also set the version for Microsoft.PowerShell.CrossCompatibility.

Ideally in future we can use a more centralised configuration, like PSScriptAnalyzer.Common.props or something, to set this in one place. We possibly also discussed a YAML configuration for this

@bergmeister
Copy link
Collaborator

bergmeister commented Jul 21, 2020

Yes to doing it also for Microsoft.PowerShell.CrossCompatibility.dll. Please update the changelog with this PR.

I am not sure why (and if) we need the existing VersionPrefix property, which is also not present in Microsoft.PowerShell.CrossCompatibility.dll at the moment

@bergmeister bergmeister changed the title changes for 1.19.1 release Set Assembly version attribute for 1.19.1 release Jul 21, 2020
@JamesWTruher JamesWTruher merged commit 8c5a638 into PowerShell:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants