Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UTF-8 BOM from text files #1567

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xtqqczze
Copy link

@xtqqczze xtqqczze commented Aug 9, 2020

PR Summary

  • Remove UTF-8 BOM from text files.
  • Specify utf-8 charset in .editorconfig to prevent IDEs inserting BOM.

PR Checklist

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtqqczze Sorry for the late review. Can you please elaborate why you need this change or why it would be beneficial to this repo?

@rjmholt
Copy link
Contributor

rjmholt commented Apr 21, 2021

Remove UTF-8 BOM from text files.

My main concern is with this part; Windows PowerShell isn't going to like BOM-less UTF-8

@rjmholt
Copy link
Contributor

rjmholt commented Apr 21, 2021

Instead, ps*1 files should probably have a BOM and other text files should not

@rjmholt
Copy link
Contributor

rjmholt commented Apr 21, 2021

The configuration should match that, but generally looks good to me

Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change ps*1 files to UTF-8 with BOM, adapt the editor config to reflect that and regenerate the resource file to resolve the conflict

@rjmholt
Copy link
Contributor

rjmholt commented Apr 23, 2021

@xtqqczze after looking through your approach in this PR and thinking about some of the particulars of this repo, I've opened #1665, which goes a bit further and tries to clean up some of the strangeness in the PSSA repo.

In particular, it specifies more settings, uses UTF-8 with BOM for PowerShell files, and makes sure test assets (some of which are deliberately encoded or formatted differently) are put in a protected assets directory

@xtqqczze
Copy link
Author

xtqqczze commented Jul 5, 2021

@rjmholt I will close once #1665 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants