-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to new signing process for release build and prep for 1.20.0 #1625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but the build seems to be broken. Also wondering whether 1.20.0
would be a better target version since the changes are all small improvements but not fixes
Add binskim scan directory
Also publish nupkg directly from signed directory
and don't publish the out directory, publishing the signed directory is enough
Fix up path for binskim
Also try to publish just the nupkg
5e9cb36
to
b6415c3
Compare
I've rebased to be up to date. @bergmeister, @rjmholt, @SydneyhSmith - Chris is suggesting that our next release should perhaps be number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- agree that 1.20 seems good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks about right to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, just a small comment about the Write-Host
invocations
Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
PR Summary
The infrastructure at MS has changed with regard to signing, this PR allows us to use it.
PR Checklist
.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.