Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to new signing process for release build and prep for 1.20.0 #1625

Merged
merged 36 commits into from
Apr 22, 2021
Merged

move to new signing process for release build and prep for 1.20.0 #1625

merged 36 commits into from
Apr 22, 2021

Conversation

JamesWTruher
Copy link
Member

PR Summary

The infrastructure at MS has changed with regard to signing, this PR allows us to use it.

PR Checklist

@JamesWTruher JamesWTruher self-assigned this Jan 13, 2021
@rjmholt rjmholt self-requested a review January 13, 2021 19:15
bergmeister
bergmeister reviewed Jan 14, 2021
View reviewed changes
Copy link
Collaborator

@bergmeister bergmeister left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but the build seems to be broken. Also wondering whether 1.20.0 would be a better target version since the changes are all small improvements but not fixes

@JamesWTruher
First cut at new release/signing build yml
150d81e
@JamesWTruher
remove display name from incorrect location
7943547
@JamesWTruher
change paths for changes in build system
232cb28
@JamesWTruher
add debugging info
21a029a
@JamesWTruher
Be sure to build all versions
daadefc
@JamesWTruher
change debugging code for 'Copy signed files'
1faf27b
@JamesWTruher
be sure to be in the correct location for creating the nupkg
d47c013
@JamesWTruher
Change nupkg building logic
fd6d5c2
@JamesWTruher
make not finding dotnet.exe a non fatal error for loading the module
57d4635
@JamesWTruher
fix path to suppression file
308f923
@JamesWTruher
debugging statements for compliance
2d1f8f4
@JamesWTruher
fix typo for credscan suppressions
5495b95 
Add binskim scan directory
@JamesWTruher
Update to publish build directory
b535c72 
Also publish nupkg directly from signed directory
@JamesWTruher
Be sure to publish the build directory
caf23fa 
and don't publish the out directory, publishing the signed directory is enough
@JamesWTruher
published signed files need their own name
f9231e5
@JamesWTruher
add exception for README.md for cred scanner
91e0921 
Fix up path for binskim
@JamesWTruher
try to get binskim to work with more direct path to assemblies
7fafc46
@JamesWTruher
debugging to find issues with signing files
484c051
@JamesWTruher
fix typo
8a6aeb2
@JamesWTruher
more debugging
0794d19
@JamesWTruher
remove debugging
39edbf6
@JamesWTruher
remove publish of nupkg
a55814b
@JamesWTruher
remove newtonsoft signing stage
275cbf2
@JamesWTruher
try the newton soft signing again
3dab1f9
@JamesWTruher
disable newtonsoft signing
29e870d
@JamesWTruher
Copy link
Member Author

I've rebased to be up to date.

@bergmeister, @rjmholt, @SydneyhSmith - Chris is suggesting that our next release should perhaps be number 1.20.0 and I wanted everyone to have a chance to provide an opinion. FWIW, I'm ok with 1.20

rjmholt
rjmholt approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- agree that 1.20 seems good

TravisEz13
TravisEz13 reviewed Feb 10, 2021
View reviewed changes
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks about right to me

@bergmeister bergmeister changed the title move to new signing process for release build and prep for 1.19.2 move to new signing process for release build and prep for 1.20.0 Feb 10, 2021
rjmholt
rjmholt approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just a small comment about the Write-Host invocations

.ci/releaseBuild.yml Outdated Show resolved Hide resolved
@JamesWTruher @rjmholt
Update .ci/releaseBuild.yml
c0714ab 
Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
rjmholt
rjmholt reviewed Apr 21, 2021
View reviewed changes
.ci/releaseBuild.yml Outdated Show resolved Hide resolved
.ci/releaseBuild.yml Outdated Show resolved Hide resolved
.ci/releaseBuild.yml Outdated Show resolved Hide resolved
.ci/releaseBuild.yml Outdated Show resolved Hide resolved
@rjmholt rjmholt merged commit 6bdc6f4 into PowerShell:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

@TravisEz13 TravisEz13 TravisEz13 left review comments

@bergmeister bergmeister bergmeister approved these changes

Assignees

@JamesWTruher JamesWTruher

Labels
Area - Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JamesWTruher @rjmholt @bergmeister @TravisEz13