Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases where the Signature generator fails catastrophically #1661

Merged
merged 9 commits into from
Apr 21, 2021

Conversation

JamesWTruher
Copy link
Member

PR Summary

In the profile collector, there are some cases when we attempt to generate a method signature the framework will generate a platform not supported exception which causes the profile generation to fail.

We're not yet shipping the collector as a standalone module (as we think we may change it in the future), but we would like the functionality to work correctly.

PR Checklist

JamesWTruher and others added 7 commits April 12, 2021 11:05
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
@rjmholt rjmholt merged commit 6e95790 into PowerShell:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants