Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRE when custom rules omit optional properties in diagnostics #1715

Merged
merged 3 commits into from
Sep 28, 2021

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Sep 16, 2021

PR Summary

Fixes #1714.

These changes allow custom rules to emit diagnostics (or PSObjects that turn into diagnostics) with optional properties unset.

PR Checklist

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only suggestion is to replace hard-coded property names with code references using things like e.g. nameof. Also, should we try to make the property query case insensitive for the property name itself as I think at the moment it'd be case sensitive

@JamesWTruher JamesWTruher merged commit a42ab5f into PowerShell:master Sep 28, 2021
@rjmholt rjmholt deleted the customrule-fix-nre branch November 20, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom rules that don't supply optional properties cause null dereference
3 participants