Also return suggestion to use PSCredential for AvoidUsingPlainTextForPassword rule #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into avoidusingplaintextforpassword-multiple-suggestions
… into avoidusingplaintextforpassword-multiple-suggestions
|
PR that fixes the UI bug in the extension, which only displayed one code action: PowerShell/PowerShellEditorServices#1749 |
andyleejordan
added a commit
to PowerShell/PowerShellEditorServices
that referenced
this pull request
Mar 31, 2022
With the recent fix in PR #1718, PSES processes now all Correction objects from PSSA but the message specifically was just taken from the last correction here. I did not notice this at first because I thought I had to tweak my rule first to emit two different messages until I realized it was another bug in PSES. Related: PowerShell/PSScriptAnalyzer#1782 Co-authored-by: Andy Schwartzmeyer <andrew@schwartzmeyer.com>
JamesWTruher
approved these changes
May 10, 2022
|
@JamesWTruher Can you please help force merge it due to the old checks removed in master that are blocking the merge? |
sdwheeler
reviewed
Jun 6, 2022
I think existing severities of old rules like this one are very inconsistent but my thinking is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1767 by also adding an option for
PSCredential.PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.