Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from docs repo #1814

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

sdwheeler
Copy link
Collaborator

PR Summary

Copies the changes from PR MicrosoftDocs/PowerShell-Docs-Modules#74 that fixes issue MicrosoftDocs/PowerShell-Docs-Modules#17.

PR Checklist

@sdwheeler
Copy link
Collaborator Author

@bergmeister For your review

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It's good we finally put the limitation around scriptblock scope into docs. I'm not sure folks will still understand it though what it means in terms of expected false positives. But this should not block this PR, I think I will take a note to add a couple of known false positives in another PR as it's a frequent source of opened issues (as well as user frustration)

@bergmeister bergmeister merged commit 323623d into PowerShell:master Jul 11, 2022
@sdwheeler sdwheeler deleted the sdw-i17-UseVars branch December 7, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants