Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AvoidLongLines: Make internal function DiagnosticSeverity private #1851

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

bergmeister
Copy link
Collaborator

PR Summary

Code analysis showed that this function is only used by the rule itself, therefore it shouldn't have been public. No change of behavior. Technically breaking but this method was never intended to be public and other rules do not have public methods to return the DiagnosticSeverity they will emit, in fact depending on the analysis they might be different.

PR Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants