Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate strongly typed resources as part of build #1855

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

bergmeister
Copy link
Collaborator

PR Summary

At the moment one needs to update the Strings.Designer.cs files when new entries are adding to String.resx files because the .NET CLI cannot generate them by default, which makes it hard for developers that do not use Visual Studio but VS-Code or just CLI. However, there is a way to make this work and generate the strongly resource as part of the build and make it work for CLI, VS-Code (when it does a restore) and Visual Studio, which uses MSBuild, see here: dotnet/msbuild#4751

PR Checklist

@bergmeister bergmeister changed the title Generate strongly typed resourced as part of build Generate strongly typed resources as part of build Oct 27, 2022
Copy link
Member

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good - it's great that we don't need to do this manually.

@JamesWTruher
Copy link
Member

@bergmeister if you could solve the merge conflict that would be great.

… into resgen

# Conflicts:
#	Rules/Strings.Designer.cs
@bergmeister
Copy link
Collaborator Author

@JamesWTruher done. resolution was easy because this PR removes Strings.Designer.cs

@bergmeister
Copy link
Collaborator Author

Close and re-open to get latest CI check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants