Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Newtonsoft.Json to 13.0.3 #1866

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 24, 2022

Since oldest supported PS version 7.2.17 now uses 13.0.3 of Newtonsoft.Json, we can use the same version for Windows PS and PS 7. But leaving in separate paths as they could diverge again in future.
https://github.com/PowerShell/PowerShell/blob/b9fc8228a40634fde610887c404904f670eb2008/src/System.Management.Automation/System.Management.Automation.csproj#L15

Bumps Newtonsoft.Json from 12.0.3 to 13.0.2.

Release notes

Sourced from Newtonsoft.Json's releases.

13.0.2

  • New feature - Add support for DateOnly and TimeOnly
  • New feature - Add UnixDateTimeConverter.AllowPreEpoch property
  • New feature - Add copy constructor to JsonSerializerSettings
  • New feature - Add JsonCloneSettings to disable copy annotations
  • Change - Add nullable annotation to JToken.ToObject(Type, JsonSerializer)
  • Change - Reduced allocations by reusing boxed values
  • Fix - Fixed MaxDepth when used with ToObject inside of a JsonConverter
  • Fix - Fixed deserializing mismatched JToken types in properties
  • Fix - Fixed merging enumerable content and validate content
  • Fix - Fixed using $type with arrays of more than two dimensions
  • Fix - Fixed rare race condition in name table when deserializing on device with ARM processors
  • Fix - Fixed deserializing via constructor with ignored base type properties
  • Fix - Fixed MaxDepth not being used with ISerializable deserialization

13.0.1

  • New feature - Add JsonSelectSettings with configuration for a regex timeout
  • Change - Remove portable assemblies from NuGet package
  • Change - JsonReader and JsonSerializer MaxDepth defaults to 64
  • Change - Change InvalidCastException to JsonSerializationException on mismatched JToken
  • Fix - Fixed throwing missing member error on ignored fields
  • Fix - Fixed various nullable annotations
  • Fix - Fixed annotations not being copied when tokens are cloned
  • Fix - Fixed naming strategy not being used when deserializing dictionary enum keys
  • Fix - Fixed serializing nullable struct dictionaries
  • Fix - Fixed JsonWriter.WriteToken to allow null with string token
  • Fix - Fixed missing error when deserializing JToken with a contract type mismatch
  • Fix - Fixed JTokenWriter when writing comment to an object
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.3 to 13.0.2.
- [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases)
- [Commits](JamesNK/Newtonsoft.Json@12.0.3...13.0.2)

---
updated-dependencies:
- dependency-name: Newtonsoft.Json
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 24, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 24, 2022

Dependabot tried to add @rjmholt, @JamesWTruher and @bergmeister as reviewers to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/PowerShell/PSScriptAnalyzer/pulls/1866/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the PowerShell/PSScriptAnalyzer repository. // See: https://docs.github.com/rest/reference/pulls#request-reviewers-for-a-pull-request

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not possible due to back compat

@bergmeister
Copy link
Collaborator

bergmeister commented Dec 8, 2022

Now that PowerShell 7.0 is out of support, we bump the version used by PowerShell Core to 13.0.1, which is the version used by the latest version of 7.2
https://github.com/PowerShell/PowerShell/blob/978d190594161a74c79e040eff3fdce8ddcff708/src/System.Management.Automation/System.Management.Automation.csproj#LL15C8-L15C8

Rules/Rules.csproj Outdated Show resolved Hide resolved
@bergmeister bergmeister changed the title Bump Newtonsoft.Json from 12.0.3 to 13.0.2 Bump Newtonsoft.Json from 12.0.3 to 13.0.2 for Windows PowerShell and 13.0.1 for PowerShell 7.x Dec 8, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 8, 2023

A newer version of Newtonsoft.Json exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Rules/Rules.csproj Outdated Show resolved Hide resolved
Rules/Rules.csproj Outdated Show resolved Hide resolved
@bergmeister bergmeister changed the title Bump Newtonsoft.Json from 12.0.3 to 13.0.2 for Windows PowerShell and 13.0.1 for PowerShell 7.x Bump Newtonsoft.Json to 13.0.3 Jan 2, 2024
@bergmeister
Copy link
Collaborator

Now latest 7.2 version also uses latest Newtonsoft version so bumped the version

Rules/Rules.csproj Outdated Show resolved Hide resolved
@JamesWTruher JamesWTruher merged commit 2245064 into master Jan 18, 2024
11 checks passed
@dependabot dependabot bot deleted the dependabot/nuget/Newtonsoft.Json-13.0.2 branch January 18, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Build dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants