Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PSAvoidUsingAliases correction extent #685

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Fix PSAvoidUsingAliases correction extent #685

merged 1 commit into from
Dec 19, 2016

Conversation

kapilmb
Copy link

@kapilmb kapilmb commented Dec 17, 2016 •
edited by raghushantha
Loading

Previously, the correction extent would include the entire command ast. This would lead to erroneous This sets the extent to mark only the first command element i.e. the command name.

Resolves PowerShell/vscode-powershell#395

This change is Reviewable

@kapilmb kapilmb merged commit 59a1bfb into development Dec 19, 2016
@kapilmb
Copy link
Author

kapilmb commented Dec 19, 2016

Thanks @daviwil

@kapilmb kapilmb deleted the kapilmb/FixAvoidAliasCorrectionExtent branch December 19, 2016 22:54
@daviwil daviwil mentioned this pull request Dec 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviwil daviwil daviwil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kapilmb @daviwil @msftclas