Fix NullReferenceException in AlignAssignmentStatement rule when CheckHashtable is enabled #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue} }' when the PSAlignAssignmentStatement setting CheckHashtable was turned on. The reason for it was because the previous implementation expected the key in a hashtable to not contain more than 1 token expression.
…until the keyStartOffset and then search for the equal token. Works mainly fine except that I get an off by one error, which leads to a false positive warning when analysing the settings file provided by issue 828.
|
@JamesWTruher Although the issue occured only in a very special scenario and enviroment, I added a test for it. But the underlying problem in the code was just that a function was returning null to something that was |
|
thanks - even though it's an unlikely error, I would rather have an additional test, just from a process perspective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #828
$MyObj | % { @{$_.Name = $_.Value} }'produces a NullReferencException when thePSAlignAssignmentStatementsettingCheckHashtableis turned onThe reason for it was because the previous implementation expected the key in a hashtable to not contain more than 1 token expression. A lazy fix would have been to use a
continuestatement in theGetExtentsfunction instead of returning null. However, the existing algorithm was improved to deal with keys containing expressions consisting of more than 1 token. The fix consists basically in traversing further until the equal statement is reached.