Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NanoServer Docker example and summarize all docker examples better #990

Merged
merged 2 commits into from
May 11, 2018

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented May 7, 2018

PR Summary

Closes #984

As per title.
I did not go into details why the different images use slightly different methods, but since behavior is always subject to be improved, I am not sure it is worthwhile putting details about issues here that might get out of date soon.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • [] NA User facing documentation needed
  • NA Change is not breaking
  • NA Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister bergmeister self-assigned this May 7, 2018
@bergmeister bergmeister changed the title Add NanoServer Docker example and unify all docker examples to use the microsoft/powershell image tags Add NanoServer Docker example and summarize all docker examples better May 7, 2018
Copy link
Member

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@JamesWTruher JamesWTruher merged commit b99ceb2 into PowerShell:development May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running PSScriptAnalyzer on nanoserver
2 participants