Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to capture MSBuild Binary logs when restore fails #24128

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Aug 8, 2024

PR Summary

This pull request introduces changes to enable MSBuild binary logging and improve the handling of build artifacts in the pipeline configuration and build scripts.

Pipeline Configuration Changes:

Build Script Enhancements:

  • build.psm1: Modified the Restore-PSPackage function to append the -bl argument for binary logging if ENABLE_MSBUILD_BINLOGS is set.
  • build.psm1: Enhanced the Restore-PSPackage function to handle and upload MSBuild binary logs if a restore operation fails and ENABLE_MSBUILD_BINLOGS is enabled.

PR Context

Binary logs are much more readable but are too big to use all the time.

PR Checklist

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Aug 8, 2024
@TravisEz13 TravisEz13 merged commit 345707c into PowerShell:master Aug 9, 2024
41 checks passed
@TravisEz13 TravisEz13 deleted the add_capture_binlogs branch August 9, 2024 17:23
Copy link
Contributor

microsoft-github-policy-service bot commented Aug 9, 2024

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

chrisdent-de pushed a commit to chrisdent-de/PowerShell that referenced this pull request Sep 12, 2024
…hell#24128)

* Capture binary logs

* Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Oct 11, 2024
…hell#24128)

* Capture binary logs

* Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Oct 16, 2024
…hell#24128)

* Capture binary logs

* Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport-7.2.x-Done BackPort-7.4.x-Approved CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants