Update parse log to handle Read/WrteMessageAsyncAdd progress percenta…

…ge to parse command.Add textDocument/completion to ValidaeSet of MesssageNameparam on Get-PsesRpcMessageResponseTime command. (#943)
PowerShell · Apr 19, 2019 · 6ea39f3 · 6ea39f3
1 parent 0ba7868
commit 6ea39f3
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 6 deletions.
diff --git a/tools/PsesLogAnalyzer/Analyze.ps1 b/tools/PsesLogAnalyzer/Analyze.ps1
@@ -126,6 +126,7 @@ function Get-PsesRpcMessageResponseTime {
         [ValidateSet(
             "textDocument/codeAction",
             "textDocument/codeLens",
+            "textDocument/completion",
             "textDocument/documentSymbol",
             "textDocument/foldingRange",
             "textDocument/formatting",

diff --git a/tools/PsesLogAnalyzer/Parse-PsesLog.ps1 b/tools/PsesLogAnalyzer/Parse-PsesLog.ps1
@@ -68,7 +68,25 @@ function Parse-PsesLog {
                 [System.IO.FileShare]::ReadWrite,
                 4096,
                 [System.IO.FileOptions]::SequentialScan)
+        $streamReader = [System.IO.StreamReader]::new($filestream, [System.Text.Encoding]::UTF8)
+
+        # Count number of lines so we can provide % progress while parsing
+        $numLines = 0
+        while ($null -ne $streamReader.ReadLine()) {
+            $numLines++
+        }
 
+        # Recreate the stream & reader. Tried seeking to 0 on the stream and having the
+        # reader discard buffered data but still wound up with in an invalid $log[0] entry.
+        $streamReader.Dispose()
+        $filestream =
+            [System.IO.FileStream]::new(
+                $Path,
+                [System.IO.FileMode]:: Open,
+                [System.IO.FileAccess]::Read,
+                [System.IO.FileShare]::ReadWrite,
+                4096,
+                [System.IO.FileOptions]::SequentialScan)
         $streamReader = [System.IO.StreamReader]::new($filestream, [System.Text.Encoding]::UTF8)
 
         function nextLine() {
@@ -105,8 +123,9 @@ function Parse-PsesLog {
                 $line = nextLine
             }
 
-            if (!$HideProgress -and ($script:logEntryIndex % 50 -eq 0)) {
-                Write-Progress "Processing log entry ${script:logEntryIndex} on line: ${script:currentLineNum}"
+            if (!$HideProgress -and ($script:logEntryIndex % 100 -eq 0)) {
+                Write-Progress "Processing log entry ${script:logEntryIndex} on line: ${script:currentLineNum}" `
+                    -PercentComplete (100 * $script:currentLineNum / $numLines)
             }
 
             [string]$timestampStr = $matches["ts"]
@@ -144,30 +163,30 @@ function Parse-PsesLog {
                 return $result
             }
 
-            if (($Method -eq 'ReadMessage') -and
+            if (($Method -eq 'ReadMessageAsync' -or $Method -eq 'ReadMessage') -and
                 ($line -match '^\s+Received Request ''(?<msg>[^'']+)'' with id (?<id>\d+)')) {
                 $result.LogMessageType = [PsesLogMessageType]::Request
                 $msg = $matches["msg"]
                 $id = $matches["id"]
                 $json = parseLogMessageBodyAsJson
                 $result.LogMessage = [PsesJsonRpcMessage]::new($msg, $id, $json.Data, $json.DataSize)
             }
-            elseif (($Method -eq 'ReadMessage') -and
+            elseif (($Method -eq 'ReadMessageAsync' -or $Method -eq 'ReadMessage') -and
                     ($line -match '^\s+Received event ''(?<msg>[^'']+)''')) {
                 $result.LogMessageType = [PsesLogMessageType]::Notification
                 $msg = $matches["msg"]
                 $json = parseLogMessageBodyAsJson
                 $result.LogMessage = [PsesNotificationMessage]::new($msg, [PsesNotificationSource]::Client, $json.Data, $json.DataSize)
             }
-            elseif (($Method -eq 'WriteMessage') -and
+            elseif (($Method -eq 'WriteMessageAsync' -or $Method -eq 'WriteMessage') -and
                     ($line -match '^\s+Writing Response ''(?<msg>[^'']+)'' with id (?<id>\d+)')) {
                 $result.LogMessageType = [PsesLogMessageType]::Response
                 $msg = $matches["msg"]
                 $id = $matches["id"]
                 $json = parseLogMessageBodyAsJson
                 $result.LogMessage = [PsesJsonRpcMessage]::new($msg, $id, $json.Data, $json.DataSize)
             }
-            elseif (($Method -eq 'WriteMessage') -and
+            elseif (($Method -eq 'WriteMessageAsync' -or $Method -eq 'WriteMessage') -and
                     ($line -match '^\s+Writing event ''(?<msg>[^'']+)''')) {
                 $result.LogMessageType = [PsesLogMessageType]::Notification
                 $msg = $matches["msg"]