Skip to content

Commit

Permalink
Skip failing completion tests on Windows PowerShell
Browse files Browse the repository at this point in the history
Some update, presumably to the CI machine as it's now no longer tied to
the .NET 3.1.28 update, is causing these two tests to fail on Windows
PowerShell. Unfortunately, this probably indicates a real bug, but we
haven't found the cause, and don't have a known change to point at.
  • Loading branch information
andyleejordan committed Aug 18, 2022
1 parent da55e8f commit e55f54f
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,10 @@ public async Task CompletesCommandFromModule()
Assert.StartsWith(CompleteCommandFromModule.GetRandomDetail, actual.Detail);
}

[Fact]
[SkippableFact]
public async Task CompletesTypeName()
{
Skip.If(VersionUtils.PSEdition == "Desktop", "Windows PowerShell has trouble with this test right now.");
(_, IEnumerable<CompletionItem> results) = await GetCompletionResultsAsync(CompleteTypeName.SourceDetails).ConfigureAwait(true);
CompletionItem actual = Assert.Single(results);
if (VersionUtils.IsNetCore)
Expand All @@ -91,10 +92,10 @@ public async Task CompletesTypeName()
}
}

[Trait("Category", "Completions")]
[Fact]
[SkippableFact]
public async Task CompletesNamespace()
{
Skip.If(VersionUtils.PSEdition == "Desktop", "Windows PowerShell has trouble with this test right now.");
(_, IEnumerable<CompletionItem> results) = await GetCompletionResultsAsync(CompleteNamespace.SourceDetails).ConfigureAwait(true);
CompletionItem actual = Assert.Single(results);
Assert.Equal(CompleteNamespace.ExpectedCompletion, actual);
Expand Down

0 comments on commit e55f54f

Please sign in to comment.