Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pester symbols for setup/teardown blocks #1892

Closed
fflaten opened this issue Aug 15, 2022 · 3 comments · Fixed by #1899
Closed

Pester symbols for setup/teardown blocks #1892

fflaten opened this issue Aug 15, 2022 · 3 comments · Fixed by #1899
Labels
Area-Pester Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@fflaten
Copy link
Contributor

fflaten commented Aug 15, 2022

Summary of the new feature / enhancement

Add document symbols for Pester's setup/teardown blocks for outline/navigation-purposes

  • BeforeAll
  • BeforeEach
  • AfterAll
  • AfterEach
  • BeforeDiscovery

The blocks are unnamed, but outline shows order and nesting so they still make sense.

Proposed technical implementation details (optional)

Only document symbols for outline. No references/definition or code lense.
@ghost ghost added the Needs: Triage Maintainer attention needed! label Aug 15, 2022
@fflaten
Copy link
Contributor Author

fflaten commented Aug 15, 2022

If this makes sense to support, I can offer to look into it. Feels like I'm getting acquainted with the symbol providers lately 😄

@fflaten
Copy link
Contributor Author

fflaten commented Aug 15, 2022 •
edited
Loading

Maybe also InModuleScope <Module>. Not as important, though it would make so much sense with the new experimental vscode sticky scroll which reuse the same symbols.
image

@nohwnd Thoughts on this (issue as a whole)?

Update: Decided to drop it because we recommend to minimize use of InModuleScope .. and ideally only for parts of code in It-tests. It would just be noisy.

@SydneyhSmith SydneyhSmith added Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs. Area-Pester and removed Needs: Triage Maintainer attention needed! labels Aug 16, 2022
@fflaten fflaten mentioned this issue Aug 17, 2022
Merged
@nohwnd
Copy link
Contributor

nohwnd commented Aug 19, 2022

@nohwnd Jakub Jares FTE Thoughts on this (issue as a whole)?

I like it. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Pester Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add symbols for Pester setup and teardown blocks fflaten/PowerShellEditorServices
3 participants
@fflaten @nohwnd @SydneyhSmith