Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add symbols for Pester setup and teardown blocks #1899

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Add symbols for Pester setup and teardown blocks #1899

merged 3 commits into from
Aug 18, 2022

Conversation

fflaten
Copy link
Contributor

@fflaten fflaten commented Aug 17, 2022

PR Summary

Adds document symbols for setup and teardown blocks used in Pester to improve navigation using outline and sticky scroll (experimental VSCode feature).

Sticky scroll and breadcrumbs:
image

Outline:
image
image

Setup/teardown symbols are excluded from workspace symbol search to avoid filling it up with thousand identical symbols like "BeforeAll { }".

PR Context

Fix #1892

@fflaten fflaten requested a review from a team August 17, 2022 15:00
@ghost ghost added Area-Pester Issue-Enhancement A feature request (enhancement). labels Aug 17, 2022
andyleejordan
andyleejordan approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, thank you again!

@andyleejordan andyleejordan enabled auto-merge (squash) August 17, 2022 16:49
@andyleejordan
Copy link
Member

Hey @fflaten, those two completion tests are now failing pretty much 100% of the time, which indicates to me something updated on the CI machines, but yeah, no idea. Anyway, I've reverted the .NET rollback which initially fixed it, and instead have skipped the tests: #1884

@andyleejordan
Copy link
Member

andyleejordan commented Aug 18, 2022 •
edited
Loading

Ok @fflaten that PR is in, can you please rebase and force-push this real quick?

@andyleejordan
Copy link
Member

Ah ha! I could rebase this one myself too.

@andyleejordan andyleejordan merged commit 17d56d9 into PowerShell:main Aug 18, 2022
@fflaten fflaten deleted the pester-symbols branch August 18, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees
No one assigned
Labels
Area-Pester Issue-Enhancement A feature request (enhancement).
Projects
No open projects
American Pharoah
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pester symbols for setup/teardown blocks
2 participants
@fflaten @andyleejordan