-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PS Core 6.0 Beta3 doesn't load in v1.4.0 #529
Comments
You're fast ;) Luckily the team caught that for me this morning and I'll be shipping an update with a fix in an hour or so. |
Is it something about |
Nah, it's that I'm not explicitly loading the Protocol DLL using Add-Type and the change they made to the AssemblyLoadContext isn't auto-loading it anymore. It's a simple fix thankfully |
Ah, so the issue I see trying to run the command from the PowerShell console is just a red herring then. OK. I'll await the fix. :-) |
If you want a quick fix for now you can just edit PowerShellEditorServices.psm1 to add the Add-Type line for Protocol |
FWIW I thought it was maybe related to the breaking change in powershell.exe positional parameters ie. position 0 is now -File instead of -Command. RE the fix, I can wait. |
This change fixes an issue caused by PowerShell Core 6.0.0-beta3's AssemblyLoadContext changes where the Protocol assembly isn't being auto-loaded when the Host assembly gets loaded. The fix is to explicitly load that assembly when loaded inside of PowerShell Core. Resolves PowerShell#529
This change fixes an issue caused by PowerShell Core 6.0.0-beta3's AssemblyLoadContext changes where the Protocol assembly isn't being auto-loaded when the Host assembly gets loaded. The fix is to explicitly load that assembly when loaded inside of PowerShell Core. Resolves #529
Add PowerShell interactive console
Just installed PS Core Beta 3 on Windows 10 CU. Fire up VSCode 1.13.0 with 1.4.0 of the PS extension, switched to PS Core 6.0 Beta 3 and got this error:
The text was updated successfully, but these errors were encountered: