Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff view crashes language server #544

Closed
ajansveld opened this issue Aug 3, 2017 · 3 comments
Closed

Diff view crashes language server #544

ajansveld opened this issue Aug 3, 2017 · 3 comments
Labels
Issue-Bug A bug to squash.

Comments

@ajansveld
Copy link

The PowerShell language server crashes when using the Hg extension and viewing a diff. This is similar to this issue: PowerShell/vscode-powershell#729 and probably related to #342.

From the extension's source code it looks like it is sending a uri with a scheme of 'hg'. Can we add this scheme as a short term fix (see e.g. the fix for git 8f82095) until #342 is resolved?

Thanks!

@daviwil
Copy link
Contributor

daviwil commented Aug 14, 2017

Hey ajansveld, I'll look into getting a quick fix done for this for the next update.

@daviwil daviwil added this to the August 2017 milestone Aug 14, 2017
@daviwil daviwil added the Issue-Bug A bug to squash. label Aug 14, 2017
@ajansveld
Copy link
Author

Thanks! I just found that the same issue occurs when using the "Compare with Saved" feature in vscode 1.15, even when the Hg extension is not installed. I will update the title accordingly.

I have attached the logs; unfortunately they do not show the file path that is causing the exception (perhaps it should?).

vscode-powershell.zip

@ajansveld ajansveld changed the title Hg extension crashes language server Diff view crashes language server Aug 15, 2017
@daviwil daviwil removed this from the August 2017 milestone Oct 27, 2017
@daviwil
Copy link
Contributor

daviwil commented Oct 27, 2017

I've got a fix prepared for this, will go out with today's update! Closing it as a duplicate of #342.

@daviwil daviwil closed this as completed Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

2 participants