Handle unsupported file URI schemes more reliably #342
Comments
daviwil
added a commit
that referenced
this issue
Jan 18, 2017
Today's VS Code Insiders release has started sending file requests with a file scheme of 'git' which causes a crash in our language server. This is a temporary fix until we add more robust file URI scheme handling with the fix to issue #342.
daviwil
added a commit
that referenced
this issue
Jan 18, 2017
Today's VS Code Insiders release has started sending file requests with a file scheme of 'git' which causes a crash in our language server. This is a temporary fix until we add more robust file URI scheme handling with the fix to issue #342.
daviwil
added a commit
to daviwil/PowerShellEditorServices
that referenced
this issue
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
VS Code keeps adding new file URI schemes that somehow end up getting passed through to our language server (usually a bug on their end). The short-term fix is always to add the unexpected URI to
Workspace.IsPathInMemorybut I think that since this keeps happening, we need an official mechanism to handle any unexpected URI scheme.Fixing this will require more robust checks in all of the code that interacts with the Workspace so I'm going to hold off on this work until at least 0.9.1.
The text was updated successfully, but these errors were encountered: