-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #1023 and #1021 #1024
Backport #1023 and #1021 #1024
Conversation
…) to add support for optionally correcting aliases as well (added in PSSA 1.18.2) (PowerShell#1021)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've added @bergmeister to the list of reviewers - I wouldn't block if he doesn't sign off in time though. This LGTM |
also update to 1.18.3 when that goes out |
@@ -1,6 +1,6 @@ | |||
{ | |||
"PSScriptAnalyzer":{ | |||
"MinimumVersion":"1.6", | |||
"MinimumVersion":"1.18.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"MinimumVersion":"1.18.2", | |
"MinimumVersion":"1.18.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change this later.
…t got broken in #1024 (#1142) * Fix PipelineIndentation configuration issue (#1050) * legacy/1.x: Update minimum PSSA version to 1.18.3 (#1052) * Fix wiring of WhitespaceInsideBrace and WhitespaceAroundPipe * revert regression from master * add trailing comma * revert PSAvoidUsingCmdletAliases change
Backport #1023 and #1021