Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #1023 and #1021 #1024

Merged
merged 3 commits into from
Sep 17, 2019
Merged

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Sep 10, 2019

Backport #1023 and #1021

bergmeister and others added 2 commits September 10, 2019 08:17
…) to add support for optionally correcting aliases as well (added in PSSA 1.18.2) (PowerShell#1021)
@rjmholt rjmholt changed the title Backport/1021 Backport #1023 and #1021 Sep 10, 2019
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt
Copy link
Member

I've added @bergmeister to the list of reviewers - I wouldn't block if he doesn't sign off in time though. This LGTM

@TylerLeonhardt
Copy link
Member

also update to 1.18.3 when that goes out

@@ -1,6 +1,6 @@
{
"PSScriptAnalyzer":{
"MinimumVersion":"1.6",
"MinimumVersion":"1.18.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"MinimumVersion":"1.18.2",
"MinimumVersion":"1.18.3",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change this later.

@TylerLeonhardt TylerLeonhardt merged commit 4710355 into PowerShell:legacy/1.x Sep 17, 2019
@rjmholt rjmholt deleted the backport/1021 branch December 11, 2019 21:41
TylerLeonhardt pushed a commit that referenced this pull request Jan 8, 2020
…t got broken in #1024 (#1142)

* Fix PipelineIndentation configuration issue (#1050)

* legacy/1.x: Update minimum PSSA version to 1.18.3 (#1052)

* Fix wiring of WhitespaceInsideBrace and WhitespaceAroundPipe

* revert regression from master

* add trailing comma

* revert PSAvoidUsingCmdletAliases change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants