Fix UNC intellisense backslash #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
😕 |
rjmholt
approved these changes
Sep 26, 2019
rkeithhill
reviewed
Sep 26, 2019
|
|
||
| // Since we want to use a "tab stop" we need to escape a few things for Textmate to render properly. | ||
| var sb = new StringBuilder(completionDetails.CompletionText) | ||
| .Replace("\\", "\\\\") |
There was a problem hiding this comment.
You might consider using a verbatim string here e.g. .Replace(@"\", @"\\") and below.
There was a problem hiding this comment.
Might as well use verbatim strings on lines 2017 & 2018 as well. Makes the reading of "replaced this with that" easier if you don't have to mentally convert esc sequences. :-)
There was a problem hiding this comment.
Yeah, yeah that's definitely nit-picking. :-) Overall LGTM.
There was a problem hiding this comment.
alright, they're everywhere now - and they're perfectly lined up!
rjmholt
approved these changes
Sep 27, 2019
TylerLeonhardt
added a commit
that referenced
this pull request
Oct 16, 2019
* fix UNC intellisense backslash * use here string * here everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes PowerShell/vscode-powershell#2116
This escapes all
\}and$so that the intellisense is properly escaped for Textmate to render it.(yes, we don't need to escape
{)